Re: pgindent vs. pgperltidy command-line arguments

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs. pgperltidy command-line arguments
Date: 2023-07-06 15:47:33
Message-ID: 825ec386-bce4-a280-3d39-47b049d640c7@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-06-21 We 07:35, Andrew Dunstan wrote:
>
>
> On 2023-06-21 We 05:09, Peter Eisentraut wrote:
>> On 20.06.23 17:38, Andrew Dunstan wrote:
>>>>> +1, although I wonder if we shouldn't follow pgindent's new lead
>>>>> and require some argument(s).
>>>>
>>>> That makes sense to me.  Here is a small update with this behavior
>>>> change and associated documentation update.
>>>
>>> I'm intending to add some of the new pgindent features to
>>> pgperltidy. Preparatory to that here's a rewrite of pgperltidy in
>>> perl - no new features yet but it does remove the hardcoded path,
>>> and requires you to pass in one or more files / directories as
>>> arguments.
>>
>> Are you planning to touch pgperlcritic and pgperlsyncheck as well?
>
>
> Yeah, it would make sense to.
>

Here's a patch that turns all these into perl scripts.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Attachment Content-Type Size
perl-check-scripts-perl.patch text/x-patch 5.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-07-06 15:58:33 Re: Reducing connection overhead in pg_upgrade compat check phase
Previous Message Tom Lane 2023-07-06 15:46:48 Re: Avoid overflow with simplehash