| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Common function for percent placeholder replacement |
| Date: | 2022-12-20 05:30:40 |
| Message-ID: | 8228593d-1ebc-e061-2c61-3815bb364385@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.12.22 10:51, Alvaro Herrera wrote:
> I think the new one is not great. I wish we could do something more
> straightforward, maybe like
>
> replace_percent_placeholders(base_command,
> PERCENT_OPT("f", filename),
> PERCENT_OPT("d", target_detail));
>
> Is there a performance disadvantage to a variadic implementation?
> Alternatively, have all these macro calls form an array.
How about this new one with variable arguments?
(Still need to think about Robert's comment about lack of error context.)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Common-function-for-percent-placeholder-replaceme.patch | text/plain | 16.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-12-20 06:09:37 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Noah Misch | 2022-12-20 05:26:50 | Re: meson files copyright |