Re: [BUG] pg_upgrade test fails from older versions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] pg_upgrade test fails from older versions.
Date: 2022-12-19 01:56:48
Message-ID: 819272.1671415008@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Anton A. Melnikov" <aamelnikov(at)inbox(dot)ru> writes:
> 2) In 60684dd83 and b5d63824 there are two changes in the set of specific privileges.
> The thing is that in the privileges.sql test there is REVOKE DELETE command
> which becomes pair of REVOKE ALL and GRANT all specific privileges except DELETE
> in the result dump. Therefore, any change in the set of specific privileges will lead to
> a non-zero dumps diff.
> To avoid this, i propose to replace any specific GRANT and REVOKE in the result dumps with ALL.
> This also made in the patch attached.

Isn't that likely to mask actual bugs?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-12-19 03:10:30 Re: [BUG] pg_upgrade test fails from older versions.
Previous Message Michael Paquier 2022-12-19 01:56:15 Re: [PATCH] Backport perl tests for pg_upgrade from 322becb60