Close stdout and stderr in syslogger

Hi!


 


Few months ago we have encountered situation when some quite big open log files were open by Postres despite being deleted.


This affects free space caluculation in out managed PostgreSQL instances.


Currently I'm investigating this issue.


We traced some roots to unclosed descriptors in Perl code of postgresql-common [0], but we still face some unclosed descriptors pointing to log file.


 


Debian tools from postgresql-common starts pg_ctl piped to logfile. Descriptor is piped to logfile and block it for delete.


That is why we can't delete logfile.1 after logrotate.


And after second logrotate logfile.1 is in "deleted" status, but can't be deleted in fact.


 


Here I apply path with possible solution. In this patch stdout and stderr pipes are just closed in syslogger.


 


--


Sviatoslav Ermilin


Yandex


 


[0] https://salsa.debian.org/postgresql/postgresql-common/commit/580aa0677edc222ebaf6e1031cf3929f847f27fb