Re: automatically generating node support functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automatically generating node support functions
Date: 2022-07-10 23:09:57
Message-ID: 815831.1657494597@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> I was just rebasing meson ontop of this and was wondering whether the input
> filenames were in a particular order:

That annoyed me too. I think it's sensible to list the "main" input
files first, but I'd put them in our traditional pipeline order:

> nodes/nodes.h \
> nodes/primnodes.h \
> nodes/parsenodes.h \
> nodes/pathnodes.h \
> nodes/plannodes.h \
> nodes/execnodes.h \

The rest could probably be alphabetical. I was also wondering if
all of them really need to be read at all --- I'm unclear on what
access/sdir.h is contributing, for example.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-10 23:12:52 Re: Extending outfuncs support to utility statements
Previous Message Peter Smith 2022-07-10 22:55:08 Re: System catalog documentation chapter