Re: On login trigger: take three

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: a(dot)sokolov(at)postgrespro(dot)ru
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: On login trigger: take three
Date: 2022-03-18 16:03:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 18 Mar 2022, at 08:24, a(dot)sokolov(at)postgrespro(dot)ru wrote:

> - auth_extra => [ '--create-role', 'repl_role' ]);
> + auth_extra => [ '--create-role', 'repl_role,regress_user' ]);

Looking at the test in question it's not entirely clear to me what the original
author really intended here, so I've changed it up a bit to actually test
something and removed the need for the regress_user role. I've also fixed the
silly mistake highlighted in the postgresql.conf.sample test.

Daniel Gustafsson

Attachment Content-Type Size
v28-0002-Add-a-new-login-event-and-login-event-trigger-su.patch application/octet-stream 25.7 KB
v28-0001-Provide-a-GUC-for-temporarily-ignoring-event-tri.patch application/octet-stream 7.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-18 16:06:44 Re: Probable CF bot degradation
Previous Message Japin Li 2022-03-18 15:49:14 Remove INT64_FORMAT in translatable strings