Re: RangeTblEntry.inh vs. RTE_SUBQUERY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RangeTblEntry.inh vs. RTE_SUBQUERY
Date: 2024-02-23 15:19:25
Message-ID: 814829.1708701565@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> On Fri, 23 Feb 2024 at 14:35, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> Various code comments say that the RangeTblEntry field inh may only be
>> set for entries of kind RTE_RELATION.

> Yes, it's explained a bit more clearly/accurately in expand_inherited_rtentry():

> * "inh" is only allowed in two cases: RELATION and SUBQUERY RTEs.

Yes. The latter has been accurate for a very long time, so I'm
surprised that there are any places that think otherwise. We need
to fix them --- where did you see this exactly?

(Note that RELATION-only is accurate within the parser and rewriter,
so maybe clarifications about context are in order.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-02-23 15:23:22 Re: RFC: Logging plan of the running query
Previous Message Robert Haas 2024-02-23 15:17:52 incremental backup mishandles XLOG_DBASE_CREATE_FILE_COPY