| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | andrey(dot)arapov(at)nixaid(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] initdb: do not exit after warn_on_mount_point |
| Date: | 2022-09-11 14:53:22 |
| Message-ID: | 813162.1662908002@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Sat, Sep 10, 2022 at 07:14:59PM +0000, andrey(dot)arapov(at)nixaid(dot)com wrote:
>> Have slightly improved the logic so that it does not report an error
>> "directory \"%s\" exists but is not empty"
>> when it is only supposed to warn the user about the mountpoint, without
>> exiting.
> This definitely isn't a typo, as it's really strongly discouraged to use a
> mount point for the data directory.
Absolutely. I think maybe the problem here is that warn_on_mount_point()
is a pretty bad name for that helper function, as this is not "just a
warning".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2022-09-11 17:07:49 | Re: why can't a table be part of the same publication as its schema |
| Previous Message | Richard Guo | 2022-09-11 10:42:03 | Check SubPlan clause for nonnullable rels/Vars |