Re: [HACKERS] SQL procedures

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] SQL procedures
Date: 2018-01-09 18:08:07
Message-ID: 80ee1f5c-fa9d-7285-ed07-cff53d4f4858@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 1/2/18 17:47, Peter Eisentraut wrote:
> On 1/2/18 11:47, Tom Lane wrote:
>> +1 --- seems like a new bool column is the thing. Or may we should merge
>> "proisprocedure" with proisagg and proiswindow into an enum prokind?
>> Although that would break some existing client-side code.
>
> prokind sounds good. I'll look into that.

Here is a patch set for that. (I just kept the pg_proc.h changes
separate for easier viewing.) It's not quite complete; some frontend
code still needs adjusting; but the idea is clear.

I think this would be a pretty good change. It doesn't appear to save a
ton amount of code, although a couple of cases where inconsistent
settings of proisagg and proiswindow had to be handed could be removed.
Because window functions are a separate kind in pg_proc but not in the
object address system, inconsistencies will remain in the system, but I
guess that's just the way it is.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Add-prokind-column-replacing-proisagg-and-proiswindo.patch text/plain 39.9 KB
0002-pg_proc.h-updates.patch.gz application/x-gzip 81.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-01-09 18:26:24 Re: [HACKERS] [PATCH] Assert that the correct locks are held when calling PageGetLSN()
Previous Message Peter Eisentraut 2018-01-09 17:49:11 Re: pgsql: Implement channel binding tls-server-end-point for SCRAM