Conflict between regression tests namespace & transactions due to recent changes

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org, exclusion(at)gmail(dot)com
Subject: Conflict between regression tests namespace & transactions due to recent changes
Date: 2023-05-15 15:27:29
Message-ID: 80d0201636665d82185942e7112257b4@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, hackers!

When running tests for version 15, we found a conflict between
regression tests namespace & transactions due to recent changes [1].

diff -w -U3 .../src/test/regress/expected/transactions.out
.../src/bin/pg_upgrade/tmp_check/results/transactions.out
--- .../src/test/regress/expected/transactions.out ...
+++ .../src/bin/pg_upgrade/tmp_check/results/transactions.out ...
@@ -899,6 +899,9 @@

RESET default_transaction_read_only;
DROP TABLE abc;
+ERROR: cannot drop table abc because other objects depend on it
+DETAIL: view test_ns_schema_2.abc_view depends on table abc
+HINT: Use DROP ... CASCADE to drop the dependent objects too.
-- Test assorted behaviors around the implicit transaction block
created
-- when multiple SQL commands are sent in a single Query message.
These
-- tests rely on the fact that psql will not break SQL commands apart
at a
...

IIUC the conflict was caused by

+SET search_path to public, test_ns_schema_1;
+CREATE SCHEMA test_ns_schema_2
+ CREATE VIEW abc_view AS SELECT a FROM abc;

because the parallel regression test transactions had already created
the table abc and was trying to drop it.

ISTM the patch diff.patch fixes this problem...

[1]
https://github.com/postgres/postgres/commit/dbd5795e7539ec9e15c0d4ed2d05b1b18d2a3b09

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
diff.patch text/x-diff 2.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-15 16:16:08 Re: Conflict between regression tests namespace & transactions due to recent changes
Previous Message Bharath Rupireddy 2023-05-15 14:39:00 Re: walsender performance regression due to logical decoding on standby changes