From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, exclusion(at)gmail(dot)com |
Subject: | Re: Conflict between regression tests namespace & transactions due to recent changes |
Date: | 2023-05-15 16:16:08 |
Message-ID: | 2165312.1684167368@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> writes:
> IIUC the conflict was caused by
> +SET search_path to public, test_ns_schema_1;
> +CREATE SCHEMA test_ns_schema_2
> + CREATE VIEW abc_view AS SELECT a FROM abc;
> because the parallel regression test transactions had already created
> the table abc and was trying to drop it.
Hmm. I'd actually fix the blame on transactions.sql here. Creating
a table named as generically as "abc" is horribly bad practice in
a set of concurrent tests. namespace.sql is arguably okay, since
it's creating that table name in a private schema.
I'd be inclined to fix this by doing s/abc/something-else/g in
transactions.sql.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2023-05-15 16:22:38 | Re: cutting down the TODO list thread |
Previous Message | Marina Polyakova | 2023-05-15 15:27:29 | Conflict between regression tests namespace & transactions due to recent changes |