Re: Mop-up from Test::More version change patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: Mop-up from Test::More version change patch
Date: 2021-11-24 02:17:22
Message-ID: 80929.1637720242@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 11/23/21 12:03, Tom Lane wrote:
>> If you set PERL then it's highly likely that you want to use
>> "prove" from the same installation. So 0001 modifies configure
>> to first check for an executable "prove" in the same directory
>> as $PERL. If that's not what you want then you should override
>> it by setting PROVE explicitly.

> Do we really have much of an issue left to solve given c4fe3199a? It
> feels a bit like a solution in search of a problem.

We don't absolutely have to do this, agreed. But I think the
current behavior fails to satisfy the POLA. As I remarked in
the other thread, I'm worried about somebody wasting time trying
to identify why their TAP test isn't behaving the way it does
when they invoke the code under the perl they think they're using.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-11-24 02:18:07 Re: parallel vacuum comments
Previous Message Mark Dilger 2021-11-24 02:14:54 Re: Granting SET and ALTER SYSTE privileges for GUCs