Re: psql - add SHOW_ALL_RESULTS option

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: 2022-03-04 08:50:20
Message-ID: 805c0496-d60d-802b-3d61-73fed38dea16@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.01.22 10:00, Fabien COELHO wrote:
>> The reason this test constantly fails on cfbot windows is a
>> use-after-free
>> bug.
>
> Indeed! Thanks a lot for the catch and the debug!
>
> The ClearOrSaveResult function is quite annoying because it may or may
> not clear the result as a side effect.
>
> Attached v14 moves the status extraction before the possible clear. I've
> added a couple of results = NULL after such calls in the code.

Are you planning to send a rebased patch for this commit fest?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-04 09:04:00 Re: pg_tablespace_location() failure with allow_in_place_tablespaces
Previous Message Dipesh Pandit 2022-03-04 08:31:50 Re: refactoring basebackup.c