Re: Bad Build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, Rod Taylor <rbt(at)zort(dot)ca>, Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bad Build
Date: 2002-03-07 05:19:27
Message-ID: 8050.1015478367@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers

Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> Yes, I see this as well.

By my count the breakage from the DOMAIN patch is:
1 shift/reduce conflict in gram.y
3 gcc warnings (at least one being obviously a bug)
1 core dump during regression tests

Bruce, what in the heck were you doing applying this patch? You knew
darn well it had not been meaningfully reviewed. Not bothering to check
for compile problems or regression failures before applying is
unforgivably sloppy work. I don't blame the submitter; I blame you,
who should have known better.

regards, tom lane

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Bruce Momjian 2002-03-07 05:53:26 Re: Bad Build
Previous Message Neil Conway 2002-03-07 04:26:54 Re: Bad Build

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-03-07 05:29:51 Re: Point in time recovery: recreating relation files
Previous Message Tatsuo Ishii 2002-03-07 05:11:10 Re: Point in time recovery: recreating relation files