From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Broken ./configure checks for __cpuid() and __cpuidex() |
Date: | 2025-07-29 03:01:03 |
Message-ID: | 804851.1753758063@sss.pgh.pa.us |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> While looking at the surroundings, I have noticed a second check
> that's incorrect in ./configure.ac, with __cpuid(). I may be missing
> something, of course, but these two typos have been introduced by
> 3dc2d62d0486, back in 2015. meson is doing these checks correctly. I
> have not been able to test that on cirrus, it seems to run into
> problems this morning. I don't know much about these instructions,
> but it seems like __get_cpuid_count() and __get_cpuid() are much more
> populate than the two others, so the impact may be lighter than I
> suspect for builds using ./configure.
That's clearly broken. Some quick googling suggests that __cpuid
and __cpuidex are Microsoft-isms, so this would only affect
autoconf-based builds on Windows, which probably explains how we
didn't notice. Still, oughta fix it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-07-29 03:07:01 | Re: Broken ./configure checks for __cpuid() and __cpuidex() |
Previous Message | Michael Paquier | 2025-07-29 02:52:12 | Re: PG 18 beta1 release notes misses mention of pg_noreturn |