| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, alvherre(at)2ndquadrant(dot)com |
| Cc: | andres(at)anarazel(dot)de, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: shared-memory based stats collector |
| Date: | 2018-11-09 13:16:31 |
| Message-ID: | 803f2d96-3b4b-f357-9a2e-45443212f13d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/9/18 9:33 AM, Kyotaro HORIGUCHI wrote:
> Hello. This is rebased version.
>
> At Thu, 8 Nov 2018 16:06:49 +0100, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <de249c3f-79c9-b75c-79a3-5e2d008548a8(at)2ndquadrant(dot)com>
>> However a quite a few extensions in contrib seem are broken now. It
>> seems fixing it is as simple as including the new bestatus.h next to
>> pgstat.h.
>
> The additional 0009 does that.
>
That does fix it, indeed. But the break happens in 0003, so that's where
the fixes should be moved - I've tried to simply apply 0009 right after
0003, but that does not seem to work because bestatus.h does not exist
at that point yet :-/
The current split into 8 parts seems quite sensible to me, i.e. that's
how it might get committed eventually. That however means each part
needs to be correct on it's own (hence fixes in 0009 are a problem).
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-11-09 14:50:19 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |
| Previous Message | Dmitry Dolgov | 2018-11-09 12:55:26 | Re: [HACKERS] [PATCH] Generic type subscripting |