Re: Make defines in pg_config_manual.h conditional?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Make defines in pg_config_manual.h conditional?
Date: 2017-04-14 17:28:28
Message-ID: 8026.1492190908@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> ATM the defines in pg_config_manual.h are largely unconditional - which
> means the file has to be edited instead of being able to override things
> via CFLAGS/COPT. Is there any good reason for doing so?

YES. If you do things like that, the installed version of
pg_config_manual.h will not reflect the way the backend was built,
which is likely to break pgxs-type builds of addon modules later.

Just edit the file.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2017-04-14 17:33:59 Re: logical replication and PANIC during shutdown checkpoint in publisher
Previous Message Andres Freund 2017-04-14 17:06:09 Make defines in pg_config_manual.h conditional?