Re: [PATCH] initdb: map Windows' new Canadian time zone names

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: CyberNative AI CEO <ceo(at)cybernative(dot)ai>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] initdb: map Windows' new Canadian time zone names
Date: 2026-10-20 01:34:05
Message-ID: 800963.1792460045@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Thanks! I'll check this and put together a finished patch.

So after a few minutes trying to compare information presented in
several different formats, I got frustrated enough to decide that some
automation is in order. If we are taking CLDR's data as gospel from
here on out, let's just make a script to generate what findtimezone.c
needs from CLDR's windowsZones.xml. A little while later I had the
attached patch series. This doesn't represent total automation, as
it expects you to run the new Perl script by hand, and you're still
responsible for moving obsoleted entries somewhere else by hand.
But given that we shouldn't need to run this very often, I figured
that addressing those things would be well past the point of
diminishing returns.

The new data that I generated this way agrees with CyberNative's
conclusions, except that there are some differences in the comment
lines, which is perhaps unsurprising since those are human-generated.
I also notice that the win32tzlist.out file that David sent has
differences that seem to amount to comment-line differences, but
I'm not really sure where that data is coming from on the Windows
side.

regards, tom lane

Attachment Content-Type Size
v1-0001-findtimezone-separate-old-Windows-zone-names-from.patch text/x-diff 9.3 KB
v1-0002-Create-infrastructure-for-building-Windows-zone-n.patch text/x-diff 6.8 KB
v1-0003-findtimezone-update-Windows-zone-name-list-for-re.patch text/x-diff 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gustavo William 2026-10-20 01:44:01 Re: enhancing pg_basebackup speeds up to ~23Gbps (small fixes + io_uring/Direct I/O)
Previous Message shihao zhong 2026-10-20 01:25:50 Re: [PG19] Promotion hangs behind a backend blocked on a stuck client