| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Valery Popov <v(dot)popov(at)postgrespro(dot)ru> |
| Subject: | Re: Password identifiers, protocol aging and SCRAM protocol |
| Date: | 2016-08-18 16:51:49 |
| Message-ID: | 7fccb99f-8465-7ac8-72d5-3f41e90ae280@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/18/2016 03:45 PM, Michael Paquier wrote:
> On Thu, Aug 18, 2016 at 9:28 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Let's take the opportunity and also move src/backend/libpq/ip.c and md5.c
>> into src/common. It would be weird to have sha.c in src/common, but md5.c in
>> src/backend/libpq. Looking at ip.c, it could be split into two: some of the
>> functions in ip.c are clearly not needed in the client, like enumerating all
>> interfaces.
>
> It would be definitely better to do all that before even moving sha.c.
Agreed.
> For the current ip.c, I don't have a better idea than putting in
> src/common/ip.c the set of routines used by both the frontend and
> backend, and have fe_ip.c the new file that has the frontend-only
> things. Need a patch?
Yes, please. I don't think there's anything there that's needed by only
the frontend, but some of the functions are needed by only the backend.
So I think we'll end up with src/common/ip.c, and
src/backend/libpq/be-ip.c. (Not sure about those names, pick something
that makes sense, given what's left in the files.)
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-18 17:28:11 | Marginal cleanup in regex code: remove typedef "celt" |
| Previous Message | Tom Lane | 2016-08-18 16:39:47 | Improving planner's checks for parallel-unsafety |