Re: Grab bag of smaller OpenSSL fixups

On 7/14/26 15:17, Daniel Gustafsson wrote:
>> On 14 Jul 2026, at 14:57, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
>> My compiler did not like the mix of both assert and nonnull attribute.
>
> Interesting, mine didn't complain, but it's also pretty redundant to have both
> so removing the Assert and keeping the cost compile-time rather than runtime
> seem the right move.

If you are curious I am running gcc 13.3.

Compiler:

gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0

Flags according to meson compile --verbose:

cc -Isrc/backend/postgres_lib.a.p -Isrc/include
-I../postgresql/src/include -I/usr/include/libxml2
-I/usr/include/security -fdiagnostics-color=always
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wpointer-arith
-Werror=vla -Wmissing-format-attribute -Wcast-function-type
-Wshadow=compatible-local -Wformat-security -Wmissing-prototypes
-Wold-style-declaration -Wold-style-definition -Wstrict-prototypes
-Wimplicit-fallthrough=5 -Wdeclaration-after-statement
-Wno-format-truncation -Wno-stringop-truncation -DUSE_VALGRIND -fPIC
-isystem /usr/include/mit-krb5 -pthread -DBUILDING_DLL -MD -MQ
src/backend/postgres_lib.a.p/libpq_be-secure-openssl.c.o -MF
src/backend/postgres_lib.a.p/libpq_be-secure-openssl.c.o.d -o
src/backend/postgres_lib.a.p/libpq_be-secure-openssl.c.o -c
../postgresql/src/backend/libpq/be-secure-openssl.c

--
Andreas Karlsson
Percona