From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Convert varatt.h macros to static inline functions |
Date: | 2025-08-05 16:41:51 |
Message-ID: | 7fae0fc0-61e3-44b5-9fbd-3abf4290a758@eisentraut.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 03.08.25 22:20, Tom Lane wrote:
> It looks like the majority vote is still in favor of writing out
> DatumGetPointer instead of using "_D()" functions, so let's roll
> with that approach.
>
> I looked through our two versions of the varatt.h changes and
> merged them. The attached is only cosmetically different from
> yours, I think --- mostly, I kept the comments I'd written.
>
> I've tested this atop 0001-0005 from [1], and it all seems good.
> I'd like to move along with getting these changes committed, and
> then I'll take another look at the 8-byte-datums-everywhere proposal.
I committed this with the required prerequisite patches. That concludes
this thread, I think. I'll follow up on the remaining work in the
"Datum as struct" thread, and the work in the "8 byte Datums" thread can
also continue.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-08-05 16:48:29 | Re: Convert varatt.h macros to static inline functions |
Previous Message | Christoph Berg | 2025-08-05 15:44:15 | Re: libpq-oauth: a mid-beta naming check |