| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> | 
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> | 
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> | 
| Subject: | Re: [PATCH] Add pretty-printed XML output option | 
| Date: | 2023-02-15 00:05:40 | 
| Message-ID: | 7f6e4bc2-c4b0-a97e-f5db-51ea300d40e6@uni-muenster.de | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On 14.02.23 23:45, Peter Smith wrote:
> Those results implied to me that this function code (in my environment
> anyway) is somehow introducing a side effect causing the *other* XML
> tests to fail.
I believe I've found the issue. It is probably related to the XML OPTION 
settings, as it seems to deliver different error messages when set to 
DOCUMENT or CONTENT:
postgres=# SET XML OPTION CONTENT;
SET
postgres=# SELECT xmlformat('');
ERROR:  invalid XML document
DETAIL:  line 1: switching encoding : no input
^
line 1: Document is empty
^
postgres=# SET XML OPTION DOCUMENT;
SET
postgres=# SELECT xmlformat('');
ERROR:  invalid XML document
LINE 1: SELECT xmlformat('');
                          ^
DETAIL:  line 1: switching encoding : no input
^
line 1: Document is empty
^
v8 attached reintroduces the SELECT xmlformat('') test case and adds SET 
XML OPTION DOCUMENT to the regression tests.
Best, Jim
| Attachment | Content-Type | Size | 
|---|---|---|
| v8-0001-Add-pretty-printed-XML-output-option.patch | text/x-patch | 19.8 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-02-15 00:20:59 | Re: We shouldn't signal process groups with SIGQUIT | 
| Previous Message | Jonathan S. Katz | 2023-02-14 23:16:18 | Re: User functions for building SCRAM secrets |