From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
Subject: | Re: Persist injection points across server restarts |
Date: | 2025-06-02 19:42:35 |
Message-ID: | 7eed8fc7526343dc3827e89b3cea9e6a5fee9470.camel@j-davis.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 2025-04-30 at 14:35 +0900, Michael Paquier wrote:
> - 0001 is a patch I have stolen from a different thread (see [1]),
> introducing InjectionPointList() that retrieves a list of the
> injection points attached.
Unless that other thread is blocked for some reason, I'd suggest just
going ahead with the SQL callable function first. That seems
independently useful.
> - 0002 extends injection_points with a new flush function, that can
> be
> used in TAP tests to persist some points across restarts. One sticky
> point is that I did not want to add any of this information in the
> core backend injection point APIs, nor to any of the backend
> structures because that's not necessary, and what's here is enough
> for
> some TAP tests.
This seems like a fair amount of complexity for a single use case.
Arguably, complexity around testing infrastructure is a lot less of a
problem than other kinds of complexity, so it might be OK. But it would
be nice if there were a couple cases that would benefit rather than
one.
Regards,
Jeff Davis
From | Date | Subject | |
---|---|---|---|
Next Message | Sami Imseih | 2025-06-02 19:44:36 | Re: Improve explicit cursor handling in pg_stat_statements |
Previous Message | Jeff Davis | 2025-06-02 19:41:47 | Re: pg_upgrade: warn about roles with md5 passwords |