Re: ispell/hunspell imprecision in error message

From: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ispell/hunspell imprecision in error message
Date: 2016-07-26 07:55:05
Message-ID: 7edc9016-72e0-274c-20a6-14971166e9ed@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.07.2016 19:53, Peter Eisentraut wrote:
> I was trying to look up the background of this error message:
>
> "Ispell dictionary supports only \"default\", \"long\", and \"num\" flag
> value"
>
> (src/backend/tsearch/spell.c)
>
> But I found that this actually talks about Hunspell format dictionaries.
> (So the man page is hunspell(5) as opposed to ispell(5).) While as far
> as the tsearch interfaces are concerned, those two are lumped together,
> should we not change the error message to refer to Hunspell?
>

Hello,

As I understand, this error message refers to the Ispell dictionary
template. This template can use various dictionary formats. Which is
confusing. Maybe would be better to change dictionary template name. But
it can break backward compatibility...

If we want to change the error message, maybe change it to the following?

"Hunspell dictionary format supports only \"default\", \"long\", and
\"num\" flag value"

--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bjorn Munch 2016-07-26 08:19:13 Re: fixes for the Danish locale
Previous Message Noah Misch 2016-07-26 07:50:37 Re: pg_dumping extensions having sequences with 9.6beta3