Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

On 7/27/19 6:52 AM, Alvaro Herrera wrote:
> On 2019-Jul-25, Michael Paquier wrote:
>
>> On Wed, Jul 24, 2019 at 11:23:30AM -0400, Alvaro Herrera wrote:
>>> Heh, yesterday I revised the original patch as attached and was about to
>>> push when the bell rang. I like this one because it keeps the comment
>>> to one line and it mentions the function name in charge of the
>>> validation (useful for grepping later on). It's a bit laconic because
>>> of the long function name and the desire to keep it to one line, but it
>>> seems sufficient to me.
>>
>> Looks fine to me. A nit: addition of braces for the if block. Even
>> if that a one-liner, there is a comment so I think that this makes the
>> code more readable.
>
> Yeah, I had removed those on purpose, but that was probably inconsistent
> with my own reviews of others' patches. I pushed it with them.

Thanks

Regards

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services