| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: identity columns |
| Date: | 2017-04-18 15:51:50 |
| Message-ID: | 7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/7/17 01:26, Vitaly Burovoy wrote:
> I've implement SET GENERATED ... IF NOT EXISTS. It must be placed
> before other SET options but fortunately it conforms with the
> standard.
> Since that form always changes the sequence behind the column, I
> decided to explicitly write "[NO] CACHE" in pg_dump.
>
> As a plus now it is possible to rename the sequence behind the column
> by specifying SEQUENCE NAME in SET GENERATED.
>
> I hope it is still possible to get rid of the "ADD GENERATED" syntax.
I am still not fond of this change. There is precedent all over the
place for having separate commands for creating a structure, changing a
structure, and removing a structure. I don't understand what the
problem with that is.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-04-18 15:53:36 | Re: identity columns |
| Previous Message | Tom Lane | 2017-04-18 15:48:07 | Re: Continuous buildfarm failures on hamster with bin-check |