Re: BUG #15306: Use pkg-config for searching libxml2 header

From: Böszörményi Zoltán <zboszor(at)pr(dot)hu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, dingxiangfei2009(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15306: Use pkg-config for searching libxml2 header
Date: 2018-08-01 09:56:07
Message-ID: 7e67be73-3c52-bc29-133f-64da148e0261@pr.hu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

2018-07-31 20:33 keltezéssel, Tom Lane írta:
> =?utf-8?q?PG_Bug_reporting_form?= <noreply(at)postgresql(dot)org> writes:
>> This is an improvement suggestion. In the configure script,
>> https://github.com/postgres/postgres/blob/master/configure.in#L896
>> this part uses `xml2-config` program to find the `libxml2` headers.
>
> Right ...
>
>> It would be more appropriate to use pkg-config program to search `libxml2`
>> headers.
>
> Why? Under what circumstances would xml2-config not be present
> (assuming that libxml2 is) or give a less desirable answer than
> pkg-config?

The Yocto cross-compiler framework (since Yocto 2.2 IIRC) does not
allow the "binconfig" scripts for XML2 and GD and for some other
libraries.

The pkg-config scripts are not just preferred but mandatory.

> What would you have us do on platforms lacking pkg-config?

That should be kept as a fallback in PKG_CHECK_MODULES().

Best regards,
Zoltán Böszörményi

>
> regards, tom lane
>
>

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message ahsan hadi 2018-08-01 10:55:11 Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Previous Message Andres Freund 2018-08-01 04:00:57 Re: could not read block 0 in file : read only 0 of 8192 bytes when doing nasty on immutable index function