| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | refactor some protocol message sending in walsender and basebackup |
| Date: | 2022-06-23 14:36:36 |
| Message-ID: | 7e4fdbdc-699c-4cd0-115d-fb78a957fc22@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some places in walsender.c and basebackup_copy.c open-code the sending
of RowDescription and DataRow protocol messages. But there are already
more compact and robust solutions available for this, using
DestRemoteSimple and associated machinery, already in use in walsender.c.
The attached patches 0001 and 0002 are tiny bug fixes I found during this.
Patches 0003 and 0004 are the main refactorings. They should probably
be combined into one patch eventually, but this way the treatment of
RowDescription and DataRow is presented separately.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-attlen-in-RowDescription-of-BASE_BACKUP-response.patch | text/plain | 976 bytes |
| 0002-Change-timeline-field-of-IDENTIFY_SYSTEM-to-int8.patch | text/plain | 1.6 KB |
| 0003-Refactor-sending-of-RowDescription-messages-in-repli.patch | text/plain | 6.7 KB |
| 0004-Refactor-sending-of-DataRow-messages-in-replication-.patch | text/plain | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2022-06-23 14:51:24 | Re: some aspects of our qsort might not be ideal |
| Previous Message | Robert Haas | 2022-06-23 14:27:03 | Re: NAMEDATALEN increase because of non-latin languages |