| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactor some protocol message sending in walsender and basebackup |
| Date: | 2022-07-01 21:36:46 |
| Message-ID: | 20220701213646.GA582729@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote:
> Some places in walsender.c and basebackup_copy.c open-code the sending of
> RowDescription and DataRow protocol messages. But there are already more
> compact and robust solutions available for this, using DestRemoteSimple and
> associated machinery, already in use in walsender.c.
>
> The attached patches 0001 and 0002 are tiny bug fixes I found during this.
>
> Patches 0003 and 0004 are the main refactorings. They should probably be
> combined into one patch eventually, but this way the treatment of
> RowDescription and DataRow is presented separately.
All 4 patches look reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-07-01 21:50:54 | Re: pg_checkpointer is not a verb or verb phrase |
| Previous Message | Tom Lane | 2022-07-01 21:32:02 | Re: Use outerPlanState macro instead of referring to leffttree |