Re: ABI Compliance Checker GSoC Project

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ABI Compliance Checker GSoC Project
Date: 2025-09-12 14:37:20
Message-ID: 7d82b130-4597-4936-9760-de18872e6331@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.09.25 17:17, David E. Wheeler wrote:
> The RC1 change surprised me a little; here’s the log:
>
>> Leaf changes summary: 1 artifact changed
>> Changed leaf types summary: 0 leaf type changed
>> Removed/Changed/Added functions summary: 0 Removed, 1 Changed, 0 Added function
>> Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable
>>
>> 1 function with some sub-type change:
>>
>> [C] 'function void CheckValidResultRel(ResultRelInfo*, CmdType, List*)' has some sub-type changes:
>> parameter 4 of type 'List*' was added
>> parameter 3 of type 'List*' changed:
>> entity changed from 'List*' to 'typedef OnConflictAction'
>> type size changed from 8 to 4 (in bytes)
>> type alignment changed from 0 to 4
> Presumably this is expected, but it looks like it might be an issue if it weren’t a pre-release change, yes?

This was a change that was intentionally backpatched in a different way
in order to preserve ABI compatibility. Compare commits 344662848ac on
REL_18_STABLE and 0b934d3994f on REL_17_STABLE. So everything is in
order. :)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2025-09-12 14:52:38 Re: ABI Compliance Checker GSoC Project
Previous Message Holger Hoffstätte 2025-09-12 14:22:51 Re: [PATCH] jit: fix build with LLVM-21