| From: | bt22kawamotok <bt22kawamotok(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH]Feature improvement for MERGE tab completion |
| Date: | 2022-09-12 08:25:44 |
| Message-ID: | 7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Thanks for updating!
>
> Compile errors have occurred, so can you fix them?
> And I think we can eliminate similar redundancies in MERGE tab
> completion and I would like you to fix them.
>
> For example,
>
> else if (TailMatches("WHEN", "MATCHED"))
> COMPLETE_WITH("THEN", "AND");
> else if (TailMatches("WHEN", "NOT", "MATCHED"))
> COMPLETE_WITH("THEN", "AND");
>
> above statement can be converted to the statement below.
>
> else if (TailMatches("WHEN", "MATCHED") ||
> TailMatches("WHEN", "NOT", "MATCHED"))
> COMPLETE_WITH("THEN", "AND");
Sorry for making such a silly mistake.
I create new path.
Please reviewing.
Kotaro Kawamoto
| Attachment | Content-Type | Size |
|---|---|---|
| fix_tab_completion_merge_v3.patch | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-09-12 08:28:38 | Re: pg_walinspect float4/float8 confusion |
| Previous Message | Hamid Akhtar | 2022-09-12 08:15:18 | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |