| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Backend memory dump analysis |
| Date: | 2018-04-06 16:41:04 |
| Message-ID: | 7d42de85-be63-6f35-cb25-7fa97e4040da@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/27/18 19:55, Tom Lane wrote:
> Seems reasonable, although I think if you were to delay setting the
> name till the end of that function, you could point to portal->name
> and avoid the extra pstrdup. Maybe that's useless microoptimization.
done
>> The term CopySetIdentifier has confused me a bit. (What's a "set
>> identifier"?) Maybe use CopyAndSetIdentifier? (We similarly have
>> MemoryContextResetAndDeleteChildren.)
>
> No objection, do you want to make the change?
and done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-06 16:41:39 | Re: [HACKERS] path toward faster partition pruning |
| Previous Message | Andres Freund | 2018-04-06 16:39:29 | Re: Excessive PostmasterIsAlive calls slow down WAL redo |