PATCH: add "--config-file=" option to pg_rewind

From: "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: PATCH: add "--config-file=" option to pg_rewind
Date: 2022-02-23 15:28:09
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


During a Patroni PR discussion
(, we realised that if one
wants to use the "-c" option on a typical Debian/Ubuntu installation
(where the config resides below /etc/postgresql/), pg_rewind needs a way
to be told where the postgresql.conf actually is.

The attached patch implements this as an option.

I'm extremely unhappy that I called it "--config-file" here, while
"postgres" itself wants "--config_file". But as the other dashed options
of pg_rewind are, well, dashed and not underscored, it seemed to be
better that the other way...

As the "-c" feature appeared in 12 and existing Debian installations are
unable to use it right now, I suggest to even backport the patch.

Oh, and I'm still not subscribed to -hackers, so the usual "please CC
me" applies!

Best regards,
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
"Ceterum censeo SystemD esse delendam" - Cato

Attachment Content-Type Size
add_configfile_to_pg_rewind.patch text/x-patch 2.9 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-23 15:30:02 Re: Frontend error logging style
Previous Message Joe Conway 2022-02-23 14:59:14 Re: List of all* PostgreSQL EXTENSIONs in the world