| From: | "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
|---|---|
| To: | andrew(dot)pogrebnoi(at)percona(dot)com |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Panic during xlog building with big values |
| Date: | 2025-10-14 07:08:12 |
| Message-ID: | 7bea0bc6-c5f3-4e6b-8258-2fd5e9fa154e@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Andy, thanks for your review!
I've checked RecordTransactionCommit too, but I don't think it can fire
similar error. Problem, that was described above, occurred because we
used external column storage without compression and with REPLICA
IDENTITY FULL.
To be honest, it's degenerate case, that can occur only in case of tuple
update/delete, when we need full row to identify updated/deleted value,
more info can be found in doc [1].
I've fixed comments with yours remarks, thanks. Patch is attached.
Also rebased patch with commit d3ba50db48e66be8804b9edf093b0f921d625425.
[1]
https://www.postgresql.org/docs/current/logical-replication-publication.html
Best regards,
Maksim Melnikov
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Pre-check-potential-XLogRecord-oversize.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-10-14 07:44:11 | Re: add function argument name to substring and substr |
| Previous Message | Arseniy Mukhin | 2025-10-14 07:02:29 | Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions |