Re: Quoting filename in using facing log messages

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Quoting filename in using facing log messages
Date: 2023-09-13 11:55:57
Message-ID: 7bc486db-9888-7d23-2cae-6068b506785f@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.09.23 13:48, Daniel Gustafsson wrote:
> Looking at ZQFUGOuS5DU4DsE4(at)paquier(dot)xyz I noticed that we had a a few instances
> of filenames in userfacing log messages (ie not elog or DEBUGx etc) not being
> quoted, where the vast majority are quoted like \"%s\". Any reason not to
> quote them as per the attached to be consistent across all log messages?

Since WAL file names have a predictable format, there is less pressure
to quote them to avoid ambiguities. But in general we should try to be
consistent, so your patch makes sense to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-09-13 12:02:47 Re: Quoting filename in using facing log messages
Previous Message Amit Kapila 2023-09-13 11:48:57 Re: Synchronizing slots from primary to standby