Re: Failure in contrib test _int on loach

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Failure in contrib test _int on loach
Date: 2019-04-30 16:32:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


> So, if other hackers are agreed with my reasoning, the suggested fix is
> sufficient and can be committed.

Patch looks right, but I think that comment should be improved in follow piece:

if (stack->blkno != GIST_ROOT_BLKNO &&
- stack->parent->lsn < GistPageGetNSN(stack->page))
+ ((stack->parent->lsn < GistPageGetNSN(stack->page)) ||
+ stack->retry_from_parent == true))
* Concurrent split detected. There's no guarantee that the
Not only concurrent split could be deteced here and it was missed long ago. But
this patch seems a good chance to change this comment.

Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-04-30 16:34:31 Re: Sv: Sv: Re: Sv: Re: ERROR: failed to add item to the index page
Previous Message Tom Lane 2019-04-30 15:51:10 Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6