From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Fix last unitialized memory warning |
Date: | 2023-08-09 15:02:46 |
Message-ID: | 7ae6b2ac-b7e4-8a19-9421-2c6e7add0188@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09.08.23 10:07, Peter Eisentraut wrote:
> On 08.08.23 17:14, Tristan Partin wrote:
>>> I was able to reproduce the warning now on Fedora. I agree with the
>>> patch
>>>
>>> - PgBenchValue vargs[MAX_FARGS];
>>> + PgBenchValue vargs[MAX_FARGS] = { 0 };
>>>
>>> I suggest to also do
>>>
>>> typedef enum
>>> {
>>> - PGBT_NO_VALUE,
>>> + PGBT_NO_VALUE = 0,
>>>
>>> to make clear that the initialization value is meant to be invalid.
>>>
>>> I also got the plpgsql warning that you showed earlier, but I
>>> couldn't think of a reasonable way to fix that.
>>
>> Applied in v2.
>
> committed
This patch has apparently upset one buildfarm member with a very old
compiler:
https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=lapwing&br=HEAD
Any thoughts?
From | Date | Subject | |
---|---|---|---|
Next Message | Junwang Zhao | 2023-08-09 15:06:48 | Re: [BackendXidGetPid] only access allProcs when xid matches |
Previous Message | Ashutosh Bapat | 2023-08-09 14:46:46 | Re: [BackendXidGetPid] only access allProcs when xid matches |