Re: [PATCH] Implement uuid_version()

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>
Subject: Re: [PATCH] Implement uuid_version()
Date: 2019-07-13 12:36:54
Message-ID: 7ac17303-ee5b-0266-29db-a3ce3baa5283@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-07-13 08:08, Fabien COELHO wrote:
> About doc: I'd consider "generation" instead of "generating" as a
> secondary index term.

We do use the "-ing" form for other secondary index terms. It's useful
because the concatenation of primary and secondary term should usually
make a phrase of some sort. The alternative would be "generation of",
but that doesn't seem clearly better.

>> (There is also precedent for redirecting the extension function to the
>> internal one by changing the SQL-level function definition using CREATE
>> OR REPLACE FUNCTION ... LANGUAGE INTERNAL. But that seems more
>> complicated and would require a new extension version. It could maybe
>> be included if the extension version is changed for other reasons.)
>
> What about avoiding a redirection with something like:
>
> Datum (* const pg_random_uuid)(PG_FUNCTION_ARGS) = gen_random_uuid;

That seems very confusing.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-07-13 12:44:13 Re: initdb recommendations
Previous Message Joe Conway 2019-07-13 11:34:22 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)