From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: NOT NULL markings for BKI columns |
Date: | 2015-04-10 02:29:52 |
Message-ID: | 7F8B12F8-B630-4C97-953C-948B79AF6463@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Apr 9, 2015, at 5:03 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> Specifically, this code chunk:
>>
>> + if (defined $attopt)
>> + {
>> + if ($attopt eq 'PG_FORCE_NULL')
>> + {
>> + $row{'forcenull'} = 1;
>> + }
>> + elsif ($attopt eq 'BKI_FORCE_NOT_NULL')
>> + {
>> + $row{'forcenotnull'} = 1;
>> + }
>> + else
>> + {
>> + die "unknown column option $attopt on column
>> $attname"
>> + }
>> + }
>
>> We should have BKI_FORCE_NULL instead of PG_FORCE_NULL in the comparison.
>
> Ick. Thanks. Fixed.
>
> Just out of interest and if you can answer: What are you using it for? I
> guess it's AS?
Yep.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-04-10 02:29:57 | Re: Supporting TAP tests with MSVC and Windows |
Previous Message | Robert Haas | 2015-04-10 02:23:30 | Re: "rejected" vs "returned with feedback" in new CF app |