| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent vs. git whitespace check |
| Date: | 2023-02-23 08:36:00 |
| Message-ID: | 7F679EEE-2860-47B8-B5DE-F7A5223ADFF9@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 23 Feb 2023, at 05:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> For my own taste, I really don't have any objection to // in isolation --
> the problem with it is just that we've got megabytes of code in the other
> style. I fear it'd look really ugly to have an intermixture of // and /*
> comment styles.
We could use the "use the style of surrounding code (comments)" approach - when
changing an existing commented function use the style already present; when
adding a net new function a choice can be made (unless we mandate a style). It
will still look ugly, but it will be less bad than mixing within the same
block.
> Mass conversion of /* to // style would answer that,
> but would also create an impossible back-patching problem.
Yeah, that sounds incredibly invasive.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Geier | 2023-02-23 08:48:35 | Re: pg_stat_statements and "IN" conditions |
| Previous Message | Jim Jones | 2023-02-23 08:20:00 | Re: [PATCH] Add pretty-printed XML output option |