Re: [PATCH] Keep git-external-diff usage text from executing

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 夏侯莯昍 <xiahoumuxuan(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Keep git-external-diff usage text from executing
Date: 2026-10-24 23:16:20
Message-ID: 7E78EFE1-607E-4535-9B70-2327F9CB1BF2@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Oct 25, 2026, at 04:52, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 23 Oct 2026, at 05:27, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 22 Oct 2026, at 22:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>>> So I'm rather inclined to just delete it instead of expending effort on fixing
>>> it.
>>
>> +1
>
> PFA patch removing it.
>
> --
> Daniel Gustafsson
>
> <0001-Remove-git-external-diff-from-tools-directory.patch>

LGTM. I also checked if there is any doc needs to be updated for the removal, and didn’t find any.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Greg Burd 2026-10-24 21:48:37 Re: Let an ordering index scan hand its ORDER BY value to the target list