Re: BUG #11986: psql uses pager inside Emacs shell buffer (not a terminal)

From: Ed Avis <eda(at)waniasset(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #11986: psql uses pager inside Emacs shell buffer (not a terminal)
Date: 2014-12-10 07:34:04
Message-ID: 7E039918541B4C4183BFDB8F015C74302E4DC4CA@WCL-EXCH02.wcl.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Thanks Bruce M. for your offer to write a patch. I looked at the psql code but it was a bit more complex than I expected (what program isn't?) so I would be happy to take you up on your offer.

For detecting the emacs 'dumb' shell mode, where a pager doesn't make sense, any of the suggested environment variable methods would work and I don't think it matters which.

Of course this small change (and it is indeed a UI enhancement, not a bug) has stirred up opinions. The way I see it is that psql is trying to be friendly by guessing whether the user wants to run a pager or not. If it were written to be simple and correct (as is the right approach for core database code) then it would never do such guessing; the pager would have to be explicitly requested. If psql is going to guess on the user's behalf, it makes sense to do a good job.

--
Ed Avis <eda(at)waniasset(dot)com>

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2014-12-10 09:55:12 Re: BUG #11986: psql uses pager inside Emacs shell buffer (not a terminal)
Previous Message Francisco Olarte 2014-12-10 07:11:21 Re: BUG #11986: psql uses pager inside Emacs shell buffer (not a terminal)