| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Adding support for SSLKEYLOGFILE in the frontend |
| Date: | 2025-06-27 09:15:02 |
| Message-ID: | 7D8546B3-AB26-4E87-B278-F7F8BF2A9170@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Jun 2025, at 23:06, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> I'll propose changes for these comments in the morning when coffee has been
> had.
The attached moves to logging on stderr along with a test for this, and also
removes the WARNING prefix that was added to the other stderr loggings since
that seems out of place compared to other stderr loggings in libpq (the
sslpassword trunction WARNING is clearly warranted, these were not). The umask
call is removed as it's not required, and a little bit of whitespace cleanup
from the original commit performed. Re macros for file modes, this is for
fopen and not open though, or am I missing something?
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-sslkeylogfile-logging.patch | application/octet-stream | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-06-27 09:25:46 | Backpatching injection point core facilities to REL_17_STABLE |
| Previous Message | jian he | 2025-06-27 08:11:47 | Re: ALTER TABLE ALTER CONSTRAINT misleading error message |