Re: [PATCH] pgcrypto: Fix sha-crypt rounds= values that do not fit in int (BUG #19743)

> On Nov 3, 2026, at 04:49, Prashant Chinnam <crprashant(at)hotmail(dot)com> wrote:
>
>> This is a pre-existing issue, not a problem introduced
>> by your patch. The code only checks whether endp
>> points to $, so it doesn't reject an empty rounds
>> value.
>>
>> I'm fine if you prefer not to include this in the
>> current patch. In that case, I can propose a separate
>> patch.
>
> Agreed, an empty rounds= silently clamping to 1000 does
> not look right, and checking num == endp would fix it.
> I would still prefer to keep it out of this patch: it is
> a behavior change (a new ERROR for input that is accepted
> today) beyond the reported bug, and I would rather not
> widen the scope of a patch that is meant to be
> backpatched to REL_18_STABLE. Please do propose it as
> a separate patch, as you offered; it stands on its own
> that way.

No problem, I will propose a patch for that.

>
> Regards,
> Prashant Chinnam<v5-0001-pgcrypto-Fix-sha-crypt-rounds-values-that-do-not-fit.patch>

Thanks for updating the patch. I will review v5 today.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/