| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Andreas Seltenreich <andreas(dot)seltenreich(at)credativ(dot)de>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add error handling to byteaout. |
| Date: | 2015-06-03 19:47:33 |
| Message-ID: | 7B69E6BD-D9D6-4234-B8BA-ADEF99111AE1@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On June 3, 2015 9:42:21 PM GMT+02:00, Andreas Seltenreich <andreas(dot)seltenreich(at)credativ(dot)de> wrote:
>Piotr Stefaniak writes:
>>>> s/int/Size/ doesn't fix anything on 32-bit machines.
>>
>> Postgres requires twos-complement representation, so that the
>> assumption that signed integer types wrap around on overflow can be
>> safely made.
Uh, no. The C standard defines signed overflow as undefined, an compilers assume it doesn't happen. The optimize based on y observation.
---
Please excuse brevity and formatting - I am writing this on my mobile phone.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-06-03 20:22:38 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Previous Message | Andreas Seltenreich | 2015-06-03 19:42:21 | Re: [PATCH] Add error handling to byteaout. |