Re: Grab bag of smaller OpenSSL fixups

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Yilin Zhang <jiezhilove(at)126(dot)com>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, Tristan Partin <tristan(at)partin(dot)io>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Grab bag of smaller OpenSSL fixups
Date: 2026-07-28 13:24:57
Message-ID: 7B131FD6-8A60-442E-88D0-E6079D21DCAB@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 28 Jul 2026, at 09:47, Yilin Zhang <jiezhilove(at)126(dot)com> wrote:

> For all other protocol versions (TLS 1.0/1.1/1.2, both frontend and backend),
> we uniformly use `#ifndef OPENSSL_NO_TLSx` — return if the library supports the protocol.
> Only the backend TLS 1.3 path uses `#ifdef OPENSSL_NO_TLS1_3` — return when the library lacks support.
> I believe this is a one-character mistake introduced during copy-paste: `ifdef` was not changed to `ifndef`.

Nice catch, thanks! Fixed.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-07-28 13:25:39 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Daniel Gustafsson 2026-07-28 13:21:00 Re: Skip .DS_Store files in check_mode_recursive