Re: Refactor SSL test framework to support multiple TLS libraries

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Refactor SSL test framework to support multiple TLS libraries
Date: 2021-03-24 23:49:47
Message-ID: 7A523793-C0D3-4191-A64A-24AFFD002974@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 25 Mar 2021, at 00:26, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Mar-25, Daniel Gustafsson wrote:
>
>> Attached is a v2 which addresses the comments raised on the main NSS thread, as
>> well as introduces named parameters for the server cert function to make the
>> test code easier to read.
>
> I don't like this patch. I think your SSL::Server::OpenSSL and
> SSL::Server::NSS packages should be doing "use parent SSL::Server";
> having SSL::Server grow a line to "use" its subclass
> SSL::Server::OpenSSL and import its get_new_openssl_backend() method
> seems to go against the grain.

I'm far from skilled at Perl module inheritance but that makes sense, I'll take
a stab at that after some sleep and coffee.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2021-03-24 23:56:24 Re: Support for NSS as a libpq TLS backend
Previous Message Alvaro Herrera 2021-03-24 23:26:30 Re: Refactor SSL test framework to support multiple TLS libraries