| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Speeding up INSERTs and UPDATEs to partitioned tables |
| Date: | 2018-11-13 15:32:33 |
| Message-ID: | 79b6c22a-1f6d-e363-334e-d41be6576544@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 11/12/18 6:17 PM, David Rowley wrote:
> On 9 November 2018 at 19:18, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I have a comment regarding how you chose to make
>> PartitionTupleRouting private.
>>
>> Using the v14_to_v15 diff, I could quickly see that there are many diffs
>> changing PartitionTupleRouting to struct PartitionTupleRouting, but they
>> would be unnecessary if you had added the following in execPartition.h, as
>> my upthread had done.
>>
>> -/* See execPartition.c for the definition. */
>> +/* See execPartition.c for the definitions. */
>> typedef struct PartitionDispatchData *PartitionDispatch;
>> +typedef struct PartitionTupleRouting PartitionTupleRouting;
>
> Okay, done that way. v16 attached.
>
Still passes check-world.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-11-13 15:34:35 | spurious(?) warnings in archive recovery |
| Previous Message | Sergei Kornilov | 2018-11-13 14:57:10 | Re: Continue work on changes to recovery.conf API |