Re: Patch a potential memory leak in describeOneTableDetails()

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: wliang(at)stu(dot)xidian(dot)edu(dot)cn, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Patch a potential memory leak in describeOneTableDetails()
Date: 2022-04-19 12:35:57
Message-ID: 795ABB3B-B81C-402C-A334-AC760006BC49@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Feb 2022, at 14:55, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 24 Feb 2022, at 07:32, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:

>> So the attached does that.
>
> I think this is reasonable, since it's pretty clear that more(1) supporting
> "-x" is fairly rare. I'll await others commenting.

The original patch which prompted this got a bit buried, the attached 0001
contains that fix (using free() which matches the surrounding code) and 0002
has the documentation fixes for the more/less -x command.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
v2-0002-Fix-out-of-date-description-mentioning-the-comman.patch application/octet-stream 1.3 KB
v2-0001-Fix-small-memory-leak-in-psql-d.patch application/octet-stream 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mats Taraldsvik 2022-04-19 12:39:12 Fwd: Declarative partitioning and partition pruning/check
Previous Message Robert Haas 2022-04-19 12:30:26 Re: using an end-of-recovery record in all cases