Re: pg_amcheck contrib application

> On 2021.03.12. 19:10 Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>
> On Fri, Mar 12, 2021 at 11:41 AM Mark Dilger
> <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> > In this next patch, your documentation patch has been applied, and the whole project has been relocated from contrib/pg_amcheck to src/bin/pg_amcheck.
>
> Committed that way with some small adjustments. Let's see what the
> buildfarm thinks.
>

Hi,

An output-formatting error, I think:

I ran pg_amcheck against a 1.5 GB table:

-- pg_amcheck --progress --on-error-stop --heapallindexed -vt myjsonfile100k

pg_amcheck: including database: "testdb"
pg_amcheck: in database "testdb": using amcheck version "1.3" in schema "public"
0/4 relations (0%) 0/187978 pages (0%)
pg_amcheck: checking heap table "testdb"."public"."myjsonfile100k"
pg_amcheck: checking btree index "testdb"."public"."myjsonfile100k_pkey"
2/4 relations (50%) 187977/187978 pages (99%), (testdb )
pg_amcheck: checking btree index "testdb"."pg_toast"."pg_toast_26110_index"
3/4 relations (75%) 187978/187978 pages (100%), (testdb )
pg_amcheck: checking heap table "testdb"."pg_toast"."pg_toast_26110"
4/4 relations (100%) 187978/187978 pages (100%)

I think there is a formatting glitch in lines like:

2/4 relations (50%) 187977/187978 pages (99%), (testdb )

I suppose that last part should show up trimmed as '(testdb)', right?

Thanks,

Erik Rijkers